-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Fix issues in integration tests hindering a coverage report for them #13084
[GeoMechanicsApplication] Fix issues in integration tests hindering a coverage report for them #13084
Conversation
…ccessible via python" This reverts commit 0b4e55d.
…ng-files-issue-in-coverage-report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small, yet important step towards making code coverage analysis with llvm-cov easier. Thank you for figuring out which tests needed to be fixed for a successful code coverage run. I have one very minor suggestion, so we're almost ready to merge this patch :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume that the white space changes in this file were unintended. Can you please revert them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems ready to be merged.
These changes are needed to get coverage output for the python tests using llvm-cov